Added GitHub signature checking feature + tests #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moliholy
force-pushed
the
github_signature
branch
from
75395a8
to
e36d52c
Compare
…to github_signature Conflicts: src/main/java/org/jenkinsci/plugins/ghprb/GhprbRootAction.java src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbPullRequestMergeTest.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbRepositoryTest.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbRootActionTest.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbTestUtil.java
Unify forks
…to github_signature Conflicts: src/main/java/org/jenkinsci/plugins/ghprb/GhprbRepository.java src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java src/main/resources/org/jenkinsci/plugins/ghprb/GhprbTrigger/config.jelly src/test/java/org/jenkinsci/plugins/ghprb/GhprbRepositoryTest.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbTestUtil.java
Correct typo 'conext' -> 'context'
Merge changes into jenkinsci
Bug with groovy config
Also fixed null pointer when there are no credentials set up yet.
Bug with groovy config
…to github_signature Conflicts: src/main/java/org/jenkinsci/plugins/ghprb/GhprbRootAction.java src/main/java/org/jenkinsci/plugins/ghprb/GhprbTrigger.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbRootActionTest.java src/test/java/org/jenkinsci/plugins/ghprb/GhprbTestUtil.java
mmitche
referenced
this pull request
in mmitche/ghprb
Dec 25, 2015
Fix log and accepted content type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon receiving a signed POST, i.e. containing a X-Hub-Signature header, that header was just ignored. Now it checks if the signature is correct, and in case it is, then it processes the POST normally.